add troubleshoot in readme on import error #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xaptosj
requested review from
0xmaayan,
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
|
i don't have merge access, if it looks good please merge for me |
xbtmatt
reviewed
Oct 21, 2023
gregnazario
approved these changes
Oct 21, 2023
README.md
Outdated
|
|
||
| If you see import error when you do this | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
Nit I think this should be typescript since it only applies to typescript
|
I agree, we should probably make a docs page somewhere for troubleshooting. We have a few flushed out examples with TypeScript already, which a user could copy paste. We'd likely just want to focus on the onboarding experience for create aptos dapp |
xbtmatt
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should document this import error due to tsconfig, im putting it in readme for now.
Test Plan
Related Links